Homec4science

Fix two minor issues with Pholio

Authored by epriestley <git@epriestley.com> on Jul 26 2013, 18:45.

Description

Fix two minor issues with Pholio

Summary:

  • One bad method call.
  • One fatal when handling a mock with no images. These "can't" exist, but we have a few old ones I think and it's probably better not to fatal. We could filter the object out completely, but this doesn't seem like a bad fix?

Test Plan: Viewed /pholio/ (although I don't think I have any imageless mocks) and viewed an outdated image.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D6574

Details

Committed
epriestley <git@epriestley.com>Jul 26 2013, 18:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8514a3c739ec: Generalize Asana-publishable feed story objects
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9827ea9c736c: Fix two minor issues with Pholio (authored by epriestley <git@epriestley.com>).Jul 26 2013, 18:45