Homec4science

Make PhabricatorActionListView logged-out user savvy

Authored by Bob Trahan <bob.trahan@gmail.com> on Jul 12 2013, 20:39.

Description

Make PhabricatorActionListView logged-out user savvy

Summary:
Fixes T2691. Now, all PhabricatorActionListViews in the codebase setObjectHref to $request->getRequestURI. This value is passed over to PhabricatorActionItems right before they are rendered. If a PhabricatorActionItem is a workflow and there is no user OR the user is logged out, we used this objectURI to construct a log in URI.

Potentially added some undesirable behavior to aggressively setUser (and later setObjectURI) from within the List on Actions... This should be okay-ish unless there was a vision of actions having different user objects associated with them. I think this is a safe assumption.

Test Plan: played around with a mock all logged out (Ref T2652) and it worked!

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2691

Differential Revision: https://secure.phabricator.com/D6416

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Jul 12 2013, 20:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb6df427c2f6d: Add a "disabled" style
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH9838251515a2: Make PhabricatorActionListView logged-out user savvy (authored by Bob Trahan <bob.trahan@gmail.com>).Jul 12 2013, 20:39