Homec4science

Phriction Action View won't render weird actions when document does not exist

Authored by Anh Nhan Nguyen <anhnhan@outlook.com> on Mar 4 2013, 16:21.

Description

Phriction Action View won't render weird actions when document does not exist

Summary:
The actions wouldn't behave as I want. Disabled them and display "Create Document" instead, since the others make no sense on a non-existing page.

The linking was error-prone btw. /phriction/edit// (how it and others would be linked) wouldn't route to anything, and even if, would result in an error anyway since non-existing docs can't be deleted nor have their history shown.

Test Plan:
verified buttons disappeard when document was not created.

verified at least history button would appear when document existed, but was deleted (should work for move, too)

Reviewers: epriestley, chad, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2384

Differential Revision: https://secure.phabricator.com/D5203

Details

Committed
epriestley <git@epriestley.com>Mar 4 2013, 16:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH92c4dfdfb19c: Fix an extra %s in BlogFeedController
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH98615c354004: Phriction Action View won't render weird actions when document does not exist (authored by Anh Nhan Nguyen <anhnhan@outlook.com>).Mar 4 2013, 16:21