Homec4science

Don't render a grip on tasks returned over AJAX to non-draggable UIs

Authored by epriestley <git@epriestley.com> on Aug 16 2014, 20:12.

Description

Don't render a grip on tasks returned over AJAX to non-draggable UIs

Summary:
Fixes T5140. When you ajax-edit a task and we send back a full-size card, we currently always put a drag grip on it.

If you clicked the "edit" thing from a priority-ordered list, this is appropriate. However, if you clicked it from some other type of list, it is not.

Pass the expected grippableness through the call.

Test Plan:

  • Edited a task from a reorderable (priority-ordered) view, got grip.
  • Edited a task from a nonreorderable (author-ordered) view, got no grip.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5140

Differential Revision: https://secure.phabricator.com/D10282

Details

Committed
epriestley <git@epriestley.com>Aug 16 2014, 20:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPH26f283fe21a5: Implement `passphrase.query` for querying credentials
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH98a847a36c26: Don't render a grip on tasks returned over AJAX to non-draggable UIs (authored by epriestley <git@epriestley.com>).Aug 16 2014, 20:12