Homec4science

Fix minor issues with PhrictionDocumentQuery

Authored by epriestley <git@epriestley.com> on Nov 12 2014, 03:47.

Description

Fix minor issues with PhrictionDocumentQuery

Summary:

  • Order checks used = but intended ==. We could probably write a lint rule for this.
  • Selecting * with a join could pick (for example) id columns from both the document and content tables and end up using the wrong one.
  • %Q expects a string and chokes on null.

Auditors: btrahan

Details

Committed
epriestley <git@epriestley.com>Nov 12 2014, 03:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8e1a4eef0400: T4666, Support Herald in Phriction
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH99bcf06c62e8: Fix minor issues with PhrictionDocumentQuery (authored by epriestley <git@epriestley.com>).Nov 12 2014, 03:49