Homec4science

Explicitly update the repository URI index after making a URI edit

Authored by epriestley <git@epriestley.com> on Dec 1 2016, 23:20.

Description

Explicitly update the repository URI index after making a URI edit

Summary:
Fixes T11936. After editing a repository URI, we were not correctly updating the URI index.

Any other edit to the repository would update the index, and this index is only really used by arc to figure out which repository a working copy belongs to, so that's how this evaded detection for this long. In particular, creating a repository would usually have an edit after any URI edits, to activate it, which would build the index correctly.

Test Plan:

  • Added a new URI to a repository.
  • Verified it was immediately reflected in the repository_uriindex table.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11936

Differential Revision: https://secure.phabricator.com/D16972

Details

Committed
epriestley <git@epriestley.com>Dec 1 2016, 23:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdc73785c4ffc: Add a "--force" argument to "bin/config done"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH99c6b53ab224: Explicitly update the repository URI index after making a URI edit (authored by epriestley <git@epriestley.com>).Dec 1 2016, 23:29