Homec4science

Limit amount of chart data passed to browser

Authored by vrana <jakubv@fb.com> on Aug 2 2012, 08:15.

Description

Limit amount of chart data passed to browser

Summary:
Firefox has a limit of ~500,000 elements which can be passed in literal array.
This amount of data is meaningless anyway because even Retina displays don't have such resolution.

Limit the amount of data to mitigate browser limitations and also reduce the page size.
Ensure that first and last element is passed.

I considered also reducing the granularity to days but I want new repositories to have nice precise graph.

Test Plan: Displayed the chart in Firefox.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3134

Details

Committed
vrana <jakubv@fb.com>Aug 2 2012, 19:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd39117798419: Fix Differential flag view bug
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH9a19cfb9de5d: Limit amount of chart data passed to browser (authored by vrana <jakubv@fb.com>).Aug 2 2012, 19:53