Homec4science

Handle tag tags properly in discovery

Authored by epriestley <git@epriestley.com> on Jun 20 2016, 20:07.

Description

Handle tag tags properly in discovery

Summary:
Fixes T11180. In Git, it's possible to tag a tag (????). When you do, we try to log the tag-object, which automatically resolves to the commit and fails.

Just skip these. If "A" points at "B" which points at "C", it's fine to ignore "A" and "B" since we'll get the same stuff when we process "C".

Test Plan:

  • Tagged a tag.
  • Pushed it.
  • Discovered it.
  • Before patch: got exception similar to the one in T11180.
  • After patch: got tag-tag skipped. Also got slightly better error messages.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11180

Differential Revision: https://secure.phabricator.com/D16149

Details

Committed
epriestley <git@epriestley.com>Jun 20 2016, 20:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf763c314e107: Fix external blog images
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9a2c2505a013: Handle tag tags properly in discovery (authored by epriestley <git@epriestley.com>).Jun 20 2016, 20:10