Homec4science

Modernizing Flag Application

Authored by Anh Nhan Nguyen <anhnhan@outlook.com> on Mar 26 2013, 22:05.

Description

Modernizing Flag Application

Summary:
Fixes a weird string in the flag dialog

Migrated to ObjectItemView (Cards)

Removed filters from side nav (unnecessary)

Go away, go away, panel. Nobody will miss you.

Adding sorting/ordering to Flag (separation like in Maniphest ordering still remaining)

Hacking our way in DifferentialRevisionListController thanks to panels (who added ->setFlush() btw? It's awesome!)

Test Plan: I would not dare to stand here if it did not work.

Reviewers: epriestley, chad, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5449

Details

Committed
epriestley <git@epriestley.com>Mar 26 2013, 22:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8fc94b02a9b0: Fix Conpherence
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9a6c912ef6cb: Modernizing Flag Application (authored by Anh Nhan Nguyen <anhnhan@outlook.com>).Mar 26 2013, 22:10