Homec4science

add committer as supported field for herald rules

Authored by Eric Stern <eric@ericstern.com> on Aug 29 2013, 15:07.

Description

add committer as supported field for herald rules

Summary: Allows building Herald rules against committer, similar to author. Useful for monitoring cherry-picked commits.

Test Plan: Applied patch, restarted php-fpm and phd daemons to ensure code changes took effect. Added a new herald rule to trigger audit when committer was me. Cherry-picked someone else's commit (author=them, committer=me) and pushed to origin. Audit was triggered.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D6838

Details

Committed
epriestley <git@epriestley.com>Aug 29 2013, 15:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd06129b81ef7: Add setEpoch() and onboard staleness to ObjectItemListView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9a95b1e7d1ef: add committer as supported field for herald rules (authored by Eric Stern <eric@ericstern.com>).Aug 29 2013, 15:07