Homec4science

Route task merges through new editor

Authored by epriestley <git@epriestley.com> on Sep 23 2013, 23:32.

Description

Route task merges through new editor

Summary:
Ref T2217. Ship "Merge in Duplicates" through the new editor. The only notable thing here is setContinueOnMissingFields().

The problem this solves is that if you add a custom field and mark it as required, all existing tasks are "invalid" since they don't have a value, and trying to edit them will raise an error like "Some Custom Field is required!". This is fine for normal edits via the UI, since the user can just select/provide a value, but surgical edits to specific fields should just ignore these errors. Add the ability to ignore these errors and use it on all the field-speific editors.

Test Plan: Merged duplicates, including "invalid" duplicates with missing fields.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2217

Differential Revision: https://secure.phabricator.com/D7084

Details

Committed
epriestley <git@epriestley.com>Sep 23 2013, 23:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6fd1e01fe79b: Run Maniphest batch edits through modern editor
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9afbb9b83b5f: Route task merges through new editor (authored by epriestley <git@epriestley.com>).Sep 23 2013, 23:32