Homec4science

Policy - move some owners code into an editor class and check policy better

Authored by Bob Trahan <btrahan@phacility.com> on Feb 3 2015, 20:41.

Description

Policy - move some owners code into an editor class and check policy better

Summary: Ref T7094. We basically need to make sure folks can see repositories before making owners packages about code within. This cleans up things a little bit by moving a bunch of logic out of the storage class and into an editor class.

Test Plan: made a package and it worked! deleted a package and it worked! discovered buggy behavior in more complicated edits and filed T7127; note this bug exists before and after this diff.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7094

Differential Revision: https://secure.phabricator.com/D11652

Details

Committed
Bob Trahan <btrahan@phacility.com>Feb 3 2015, 20:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc65b58b21c32: Clean up a ConduitException around Diffusion merges
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH9b65370398cc: Policy - move some owners code into an editor class and check policy better (authored by Bob Trahan <btrahan@phacility.com>).Feb 3 2015, 20:41