Homec4science

Handle refreshing profile image with expired OAuth token

Authored by vrana <jakubv@fb.com> on Apr 19 2012, 06:30.

Description

Handle refreshing profile image with expired OAuth token

Summary:
If OAuth token is expired then refreshing profile image doesn't work.
This diffs solves it this way:

  • Hide Refresh Profile Image button with expired token.
  • Display Refresh Token with expired token.
  • Update token after logging-in.

Test Plan:
Wait until token expires.
/settings/page/facebook/ - no Refresh Profile Image button.
Refresh Token.
Refresh Profile Image.

Reviewers: epriestley, jungejason

Reviewed By: epriestley

CC: michalburger1, aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2281

Details

Committed
vrana <jakubv@fb.com>Apr 19 2012, 18:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH204b6694af1a: Improve performance of empty search
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH9be054443fe5: Handle refreshing profile image with expired OAuth token (authored by vrana <jakubv@fb.com>).Apr 19 2012, 18:30