Homec4science

Update Owners auditing rules for multiple reviewers

Authored by epriestley <git@epriestley.com> on May 17 2016, 19:55.

Description

Update Owners auditing rules for multiple reviewers

Summary:
Ref T10939. Fixes T10181. This slightly simplifies, then documents the auditing rules, which haven't been updated for a while. In particular:

  • If an owner authored the change, never audit.
  • Examine all reviewers to determine reviewer audit status, not just the first reviewer.
  • Simplify some of the loading code a bit.

Test Plan:

  • Ran bin/repository reparse --owners <commit> --force to trigger this stuff.
  • Verified that the web UI did reasonable things with resulting audits.
  • Read documentation.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10181, T10939

Differential Revision: https://secure.phabricator.com/D15939

Details

Committed
epriestley <git@epriestley.com>May 17 2016, 22:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPH809c7bf996af: Allow users to manage package dominion rules
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9c24798e64c9: Update Owners auditing rules for multiple reviewers (authored by epriestley <git@epriestley.com>).May 17 2016, 22:46