Homec4science

Default "environment.append-paths" to include likely paths

Authored by epriestley <git@epriestley.com> on May 27 2013, 22:40.

Description

Default "environment.append-paths" to include likely paths

Summary:
A few more of these issues have cropped up recently. Basically:

  • Webservers often (by default, I guess?) have a different or nonexistent $PATH.
  • Users have a hard time figuring this out, since it's not obvious that the webserver might have a different configuration than the CLI, and they can run "git" and such themselves fine, and they don't normally use SetEnv or similar in webserver config.

I've been pursuing one prong of attack here (better detection and more tailored errors); this is a second prong (try to just guess the configuration correctly).

In 99% of cases, the binaries in question are in one of these three places, so just make them the default appended paths. If users have wacky configs they can override the setting.

Test Plan: Viewed config locally.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D6039

Details

Committed
epriestley <git@epriestley.com>May 27 2013, 22:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe434edc4558a: Make "arc tasks --unassigned" actually find unassigned tasks
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9c925464baf8: Default "environment.append-paths" to include likely paths (authored by epriestley <git@epriestley.com>).May 27 2013, 22:40