Homec4science

Modernize OAuthserver and provide more context on "no permission" exception

Authored by epriestley <git@epriestley.com> on Sep 3 2015, 19:05.

Description

Modernize OAuthserver and provide more context on "no permission" exception

Summary:
Ref T7173. Depends on D14049. Now that Phacility can install custom exception handlers, this puts enough information on the exception so that we can figure out what to do with it.

  • Generally modernize some of this code.
  • Add some more information to PolicyExceptions so the new RequestExceptionHandler can handle them properly.

Test Plan: Failed authorizations, then succeeded authorizations. See next diff.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7173

Differential Revision: https://secure.phabricator.com/D14050

Details

Committed
epriestley <git@epriestley.com>Sep 3 2015, 19:05
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1fc60a9a6e70: Modularize Aphront exception handling
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9d0332c2c0a4: Modernize OAuthserver and provide more context on "no permission" exception (authored by epriestley <git@epriestley.com>).Sep 3 2015, 19:05