Homec4science

Speed up DiffusionBrowseFileController by removing call to array_merge

Authored by Jacob Hurwitz <jhurwitz@dropbox.com> on May 10 2014, 03:06.

Description

Speed up DiffusionBrowseFileController by removing call to array_merge

Summary: Some profiling using XHProf in the Dark Console showed me that Diffusion was wasting a ton of time on array_merge. This change sped up the loading of a large file in Diffusion from 16.8 seconds to 2.4 seconds.

Test Plan: Load files in Diffusion. They all look good. Also, use a PHP shell to try to manually verify that I still kinda remember some PHP and, yes, this is functionally equivalent to what was there before.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9032

Details

Committed
epriestley <git@epriestley.com>May 10 2014, 03:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe96c363eefe7: Add SMS support
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9d0d1ac42f8a: Speed up DiffusionBrowseFileController by removing call to array_merge (authored by Jacob Hurwitz <jhurwitz@dropbox.com>).May 10 2014, 03:06