Use large text columns to store IP addresses
9d125b459ea8
Actions

Authored by epriestley <git@epriestley.com> on Feb 2 2016, 18:59.

Description

Use large text columns to store IP addresses

Summary: Fixes T10259. There was no real reason to do this ip2long() stuff in the first place -- it's very slightly smaller, but won't work with ipv6 and the savings are miniscule.

Test Plan:

Ran migration.
Viewed logs in web UI.
Pulled and pushed.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10259

Differential Revision: https://secure.phabricator.com/D15165

Details

Committed

epriestley <git@epriestley.com>

Feb 2 2016, 19:13

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH1d939e0bd867: Add project icon/type to Project Profile

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9d125b459ea8: Use large text columns to store IP addresses (authored by epriestley <git@epriestley.com>).Feb 2 2016, 19:13

Changes (10)

				Path
	A			resources/sql/autopatches/20160202.ipv6.1.sql
	A			resources/sql/autopatches/20160202.ipv6.2.php
	M			src/aphront/AphrontRequest.php
	M			src/applications/config/schema/PhabricatorConfigSchemaSpec.php
	M			src/applications/diffusion/controller/DiffusionServeController.php
	M			src/applications/diffusion/engine/DiffusionCommitHookEngine.php
	M			src/applications/diffusion/view/DiffusionPushLogListView.php
	M			src/applications/people/view/PhabricatorUserLogView.php
	M			src/applications/repository/storage/PhabricatorRepositoryPullEvent.php
	M			src/applications/repository/storage/PhabricatorRepositoryPushEvent.php