Homec4science

Improve `differential.createinline`

Authored by epriestley <git@epriestley.com> on Jul 17 2012, 21:06.

Description

Improve differential.createinline

Summary:

  • Share code between createinline and getcomments
  • Make them both extend the base class.
  • Sync up the parameters (this is more or less nonbreaking since the call is ~6 hours old).

Test Plan: Created and fetched inlines via the API.

Reviewers: alanh, vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1500

Differential Revision: https://secure.phabricator.com/D2988

Details

Committed
epriestley <git@epriestley.com>Jul 17 2012, 21:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH02f40fd7ef48: Allow noncritical blocks in email bodies to be disabled via config
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9d26ef424854: Improve `differential.createinline` (authored by epriestley <git@epriestley.com>).Jul 17 2012, 21:06