Homec4science

Make updates of rejected revisions behave correctly again

Authored by epriestley <git@epriestley.com> on Mar 5 2014, 19:47.

Description

Make updates of rejected revisions behave correctly again

Summary:
Ref T2222. Ref T4481. Specifically:

  • When a revision is updated, change all "Reject" reviewers to "Reject Prior".
  • Change status to "Needs Review".
  • Update the state logic to account for this properly.

Test Plan:

  • Created a revision as user A, with B as a reviewer.
  • Rejected as B.
  • Updated the revision as A.
  • Saw revision in "needs review" state, with B as a "Rejected Prior" reviewer.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4481, T2222

Differential Revision: https://secure.phabricator.com/D8402

Details

Committed
epriestley <git@epriestley.com>Mar 5 2014, 19:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH857e3aee83de: Improve ApplicationTransaction behavior for poorly constructed transactions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9da6ec208111: Make updates of rejected revisions behave correctly again (authored by epriestley <git@epriestley.com>).Mar 5 2014, 19:47