Homec4science

Further corrections to Conpherence updates

Authored by epriestley <git@epriestley.com> on Apr 2 2013, 20:27.

Description

Further corrections to Conpherence updates

Summary:
Apparently I am crazy and didn't test D5537 propertly at all. In particular:

  • Currently, the update sends back new "people" and "files" widgets. The "people" widget has a tokenizer, which fatals when the behavior initializes without the widget in the DOM. For now, disable widget updates on replies. I'll fix this in a future diff.
  • Currently, we don't update the "last_transaction_id" in the form itself, so the first reply sends back 1 message, the next 2 messages, etc. Update the input.
  • The transaction paging doesn't and has never worked, I am crazy. Make it actually work.

Test Plan:
computers are too hard

(also, this is why I hate Javascript)

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5538

Details

Committed
epriestley <git@epriestley.com>Apr 2 2013, 20:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd7951bec56cc: Build an AphrontMultiColumnView, use on workboards.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9db4feda09c3: Further corrections to Conpherence updates (authored by epriestley <git@epriestley.com>).Apr 2 2013, 20:27