Homec4science

Fix some issues with Maniphest inbound email

Authored by epriestley <git@epriestley.com> on May 13 2013, 17:10.

Description

Fix some issues with Maniphest inbound email

Summary:
Fixes T3181.

  • Inbound bugs@ mail is broken right now if it doesn't use the new external user stuff, because it calls $user->getPhabricatorUser() on an object which is already a PhabricatorUser. Instead, build the right $user object from the external user earlier on.
  • Maniphest mail is nuking or otherwise awkwardly altering CCs. Make this work properly.
  • Make sure "!unsubscribe" works correctly.

Test Plan: Sent bugs@ mail. Sent CC mail. Sent "!unsubscribe" mail.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran, tido

Maniphest Tasks: T3181

Differential Revision: https://secure.phabricator.com/D5911

Details

Committed
epriestley <git@epriestley.com>May 13 2013, 17:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9c87ba8b09a7: parse with %s as `number_format()` returns stirng
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9e6da4220611: Fix some issues with Maniphest inbound email (authored by epriestley <git@epriestley.com>).May 13 2013, 17:10