Homec4science

Use standard subscribers effects in Herald Adapter for revisions

Authored by epriestley <git@epriestley.com> on Jun 8 2015, 19:32.

Description

Use standard subscribers effects in Herald Adapter for revisions

Summary:
Ref T8455. Use standard effects for revisions, instead of a custom effect.

This fixes the major issue (conduit error) in T8455 because the standard effect now performs PHID type filtering.

This retains other behaviors (in particular: not re-CC'ing explicitly removed CCs).

Test Plan:

  • With a Herald rule that adds a mailing list as a CC, created a revision before the change and hit the error in T8455. After the change, saw correct behavior.
  • Wrote a normal Herald rule to add CCs and created a revision, saw it fire properly.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8455

Differential Revision: https://secure.phabricator.com/D13183

Details

Committed
epriestley <git@epriestley.com>Jun 8 2015, 19:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1e918eecfaab: Use standard subscribers effects in Herald Adapter for tasks
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9e88ede69d90: Use standard subscribers effects in Herald Adapter for revisions (authored by epriestley <git@epriestley.com>).Jun 8 2015, 19:32