Homec4science

Speed up loading of diffs with a lot of unit test failures

Authored by Joel Beales <joelb@fb.com> on Nov 19 2013, 21:06.

Description

Speed up loading of diffs with a lot of unit test failures

Summary:
We've been having trouble with viewing diffs timing out when there's a lot of unit test failures. It was caused by formatting userdata for every single failure. The expensive part of this was actually creating the engine for every result, so moved the construction outside of the loop.

Diffs that timed out (2 min) loading before load in around 6 seconds now.

Test Plan: Loaded diffs that used to time out. Verified that details still looked right when Show Full Unit Test Results Is Clicked.

Reviewers: epriestley, keegancsmith, lifeihuang, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran, andrewjcg

Differential Revision: https://secure.phabricator.com/D7581

Details

Committed
Joel Beales <joelb@fb.com>Nov 20 2013, 00:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd9db1d61e0a6: Restore population of `ownerOrdering` to ManiphestTasks
Branches
Unknown
Tags
Unknown

Event Timeline

Joel Beales <joelb@fb.com> committed rPH9efcbc4ee958: Speed up loading of diffs with a lot of unit test failures (authored by Joel Beales <joelb@fb.com>).Nov 20 2013, 00:19