Homec4science

Fix a fatal in Calendar widget in Conpherence

Authored by epriestley <git@epriestley.com> on Jun 15 2015, 22:51.

Description

Fix a fatal in Calendar widget in Conpherence

Summary:
Fixes T8548. This needs to be cleaned up more generally at some point, but stop the bleeding for now.

If a thread member is invited to an event with a non-thread-member host, we try to render the host but don't have their handle (this is a holdover from the bygone days of events as statuses).

For now, just don't render anything. In the future, it might be nice to render (some of?) the attendees who are thread members, but I suspect we may revisit this widget more generally.

Test Plan:

  • As a non thread-member, created an event and invited a thread member.
  • Viewed thread as thread-member.
  • Saw widget fatal.
  • Applied patch.
  • As thread-member, saw widget render with just "9AM-10AM", instead of "host, 9AM-10AM".

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8548

Differential Revision: https://secure.phabricator.com/D13299

Details

Committed
epriestley <git@epriestley.com>Jun 15 2015, 22:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6aa494bd2523: Fix missing property on HarbormasterBuildStepImplementation
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9f1235d87512: Fix a fatal in Calendar widget in Conpherence (authored by epriestley <git@epriestley.com>).Jun 15 2015, 22:51