Homec4science

Remove ajaxey comment magic in Pholio, and also some bugs

Authored by epriestley <git@epriestley.com> on Jun 21 2014, 21:50.

Description

Remove ajaxey comment magic in Pholio, and also some bugs

Summary:
Fixes T5424.

  • One concrete issue: drafts were not being cleared properly because __draft__ was not set on submission. This (mostly) fixes phantom drafts.
  • This ajax comment magic feels weird and floaty and generally has problems. For example, if you add subscribers or inlines, all the stuff on the page which represents those won't update automatically. Instead, just reload. Maybe we'll ajax this stuff some day, but it feels like a net negative for now.
  • Also remove it from other applications where it's currently used.
  • Fix an issue with inline previews.

Test Plan: Made some comments on a mock, everything worked normally like I expected it to.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5424

Differential Revision: https://secure.phabricator.com/D9649

Details

Committed
epriestley <git@epriestley.com>Jun 21 2014, 21:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc9a195369f25: Add email preferences to Pholio
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9f2efd0fa048: Remove ajaxey comment magic in Pholio, and also some bugs (authored by epriestley <git@epriestley.com>).Jun 21 2014, 21:50