Homec4science

Don't create directories as `0777` by default.

Authored by Joshua Spence <josh@joshuaspence.com> on Jun 17 2014, 18:58.

Description

Don't create directories as 0777 by default.

Summary: Currently, Filesystem::createDirectory('...') will create a directory with (rather open) 0777 permissions (regardless of the return value of umask()). In particular, the .git/arc directory (or similar directory for another VCS) will have 0777 permissions.

Test Plan: Removed the .git/arc directory and ran arc lint. Verified that the .git/arc directory had more restrictive permissions than 0777.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9594

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jun 17 2014, 18:58
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUc578d0e9e7ed: Modernize `.arclint` file.
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHU0027e97cd6cb: Don't create directories as `0777` by default. (authored by Joshua Spence <josh@joshuaspence.com>).Jun 17 2014, 18:58