Homec4science
Authored by Nick Harper <nharper@fb.com> on Apr 4 2013, 00:38.

Description

Redo D5527

Summary:
If the PhutilURI parser tries parsing an invalid uri (or incorrectly parses
a uri), the whole input ends up in the path. The way that D5527 handled ensuring
that paths are absolute resulted in incorrect output from the __toString()
method.

PhutilURI still doesn't parse uris correctly (like javascript:alert()) - I
might go back later to make this RFC 3986 compliant, but a few things depend
on the broken behavior and need to be fixed.

Test Plan: arc unit --everything

Reviewers: epriestley, wez

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5566

Details

Committed
Nick Harper <nharper@fb.com>Apr 4 2013, 00:38
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU9f8792b43425: Allow PhutilDeferredLog to have no path on disk
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPHU023773d4110e: Redo D5527 (authored by Nick Harper <nharper@fb.com>).Apr 4 2013, 00:38