Homec4science

Add PhutilGitURI for parsing scp-style Git URIs

Authored by epriestley <git@epriestley.com> on Jul 23 2012, 20:17.

Description

Add PhutilGitURI for parsing scp-style Git URIs

Summary:
See T1529.

We currently convert "scp-style" URIs into normal URIs in Phabricator:

git@host:path -> ssh://git@host/path

This isn't correct; paths in the scp-style URIs are resolved relatively, while paths in the normal-style URIs are resolved absolutely.

Since we can't do this transformation any more, add a real parser so we can replace the transformation code in Phabricator with something sensible.

Test Plan: Unit test coverage.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1529

Differential Revision: https://secure.phabricator.com/D3033

Details

Committed
epriestley <git@epriestley.com>Jul 23 2012, 20:17
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU5363f990f834: Fix various TempFile issues
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU10965d5b649e: Add PhutilGitURI for parsing scp-style Git URIs (authored by epriestley <git@epriestley.com>).Jul 23 2012, 20:17