Split phlog() out of a class definition file
Summary: We can't put functions and classes in the same file any longer.
Test Plan:
This warning vanished from the new linter:
>>> Lint for /INSECURE/devtools/libphutil/src/error/PhutilErrorHandler.php:
Error (PHL3) One Class Per File
File 'error/PhutilErrorHandler.php' mixes function (phlog,
phutil_error_listener_example) and class/interface (PhutilErrorHandler)
definitions in the same file. A file which declares a class or an
interface MUST declare nothing else.
342 * @return void
343 * @group error
344 */
345 function phutil_error_listener_example($event, $value, array $metadata) {
346 throw new Exception("This is just an example function!");
347 }Also ran 'arc' and loaded Phabricator.
Reviewers: vrana, btrahan
Reviewed By: vrana
CC: aran
Maniphest Tasks: T1103
Differential Revision: https://secure.phabricator.com/D2596