Homec4science

Only SIGINT the daemon itself, not its entire process group

Authored by epriestley <git@epriestley.com> on Feb 25 2015, 23:35.

Description

Only SIGINT the daemon itself, not its entire process group

Summary: Signaling the process group is correct for SIGTERM and SIGKILL (nongraceful exits) but not for SIGINT (graceful exit). Subprocesses of the daemon may exit abruptly on SIGINT, which is not consistent with the requested behavior ("exit gracefully").

Test Plan: Ran bin/phd start, bin/phd stop.

Reviewers: btrahan, hach-que

Reviewed By: hach-que

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11889

Details

Committed
epriestley <git@epriestley.com>Feb 25 2015, 23:35
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUa259a43911f6: Put version information in stack traces
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU124e5a41e086: Only SIGINT the daemon itself, not its entire process group (authored by epriestley <git@epriestley.com>).Feb 25 2015, 23:35