Homec4science

Share Env/CWD methods between Passthru + ExecFuture, expose Env

Authored by epriestley <git@epriestley.com> on Apr 19 2016, 01:21.

Description

Share Env/CWD methods between Passthru + ExecFuture, expose Env

Summary:
Ref T10751. This is several layers deep: I want to unit test environmental configuration for git/svn/hg commands, but there's currently no way to read it.

It's also duplicated between Passthru and ExecFuture classes.

Extend them from one class doing CWD + Env stuff. Clean that stuff up a little. Add a getEnv() for reading so I can do unit tests.

Test Plan: Ran arc unit --everything, see next diff for unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10751

Differential Revision: https://secure.phabricator.com/D15751

Details

Committed
epriestley <git@epriestley.com>Apr 19 2016, 13:49
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU1ea69b48e36d: add es_ES to PhutilLocal
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU1341c014ca7c: Share Env/CWD methods between Passthru + ExecFuture, expose Env (authored by epriestley <git@epriestley.com>).Apr 19 2016, 13:49