Homec4science

Support file attachments on HTTPSFuture

Authored by epriestley <git@epriestley.com> on Apr 22 2014, 00:35.

Description

Support file attachments on HTTPSFuture

Summary: @zeeg wants this for some build stuff and we'd like it in general to make Mailgun work better. It's a bit messy because of how cURL works. See pages of comments inline.

Test Plan:

  • Added tests for the parser stuff.
  • Made various requests with and without file attachments and saw them encode data as expected.
  • Made some dangerous requests (with "@") and saw them fail.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley, zeeg

Differential Revision: https://secure.phabricator.com/D8831

Details

Committed
epriestley <git@epriestley.com>Apr 22 2014, 00:35
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU3ca028dec2e7: Provide slightly better cURL debugging instructions for custom.pem files
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU159b5065d9d4: Support file attachments on HTTPSFuture (authored by epriestley <git@epriestley.com>).Apr 22 2014, 00:35