Homec4science

Add "LinesOfALargeExecFuture" abstraction

Authored by epriestley <git@epriestley.com> on May 12 2012, 00:07.

Description

Add "LinesOfALargeExecFuture" abstraction

Summary:

  • This is for D2457.
  • We have an existing LinesOfALargeFile class for buffered, line-oriented processing of large input streams.
  • Splits existing LinesOfALargeFile class into abstract LinesOfALarge and concrete LinesOfALargeFile.
  • Changes next() algorithm to be iterative rather than recursive.
  • Allows the user to specify a line delimiter character.
  • Adds concrete subclass LinesOfALargeExecFuture.
  • Document and cover all three classes.

Test Plan: Ran unit tests.

Reviewers: csilvers, btrahan

Reviewed By: csilvers

CC: aran

Differential Revision: https://secure.phabricator.com/D2459

Details

Committed
epriestley <git@epriestley.com>May 12 2012, 00:07
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU0cc4b2cf2470: Disable `xdebug.max_nesting_level` in __init_script__.php
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU16876003ef3f: Add "LinesOfALargeExecFuture" abstraction (authored by epriestley <git@epriestley.com>).May 12 2012, 00:07