Homec4science

Allow intra-domain links in Remarkup

Authored by Alan Huang <alanh@fb.com> on Aug 14 2012, 23:01.

Description

Allow intra-domain links in Remarkup

Summary:
When parsing a link of the form [[/path/...]], the protocol
gets marked as '', which is not allowed, so the link doesn't get
linkified and later turns into a Phriction link. The previous line
specifically allows this case, so it's a bit silly. So if the URI starts
with /, skip the protocol check.

Test Plan: Try linking things in Differential comments.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, starruler

Differential Revision: https://secure.phabricator.com/D3281

Details

Committed
Alan Huang <alanh@fb.com>Aug 14 2012, 23:01
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUe6567e5a0844: Merge pull request #14 from yunake/master
Branches
Unknown
Tags
Unknown

Event Timeline

Alan Huang <alanh@fb.com> committed rPHU18e8719b1256: Allow intra-domain links in Remarkup (authored by Alan Huang <alanh@fb.com>).Aug 14 2012, 23:01