Homec4science

Add a read buffer size to PhutilChannel

Authored by epriestley <git@epriestley.com> on Dec 16 2013, 21:35.

Description

Add a read buffer size to PhutilChannel

Summary: Ref T4241. See D7772. Just like ExecFuture, allow the internal channel buffer to be limited in size so when we're plugging a fast pipe into a slow pipe we don't end up with all of the data in memory (subject to actually using these features).

Test Plan: Added unit tests.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4241

Differential Revision: https://secure.phabricator.com/D7774

Details

Committed
epriestley <git@epriestley.com>Dec 16 2013, 21:35
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU6eaf191e84e9: Use PhutilRope for Channel write buffers and make write buffer details public
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU1b39ae6f1a42: Add a read buffer size to PhutilChannel (authored by epriestley <git@epriestley.com>).Dec 16 2013, 21:35