Homec4science

Disable cURL "Expect:" header

Authored by epriestley <git@epriestley.com> on Feb 27 2013, 16:33.

Description

Disable cURL "Expect:" header

Summary:
Fixes T2612. That task has a pretty good explanation of this issue. It's been on my radar for a while, but basically:

  • By default, cURL sends "Expect: 100 continue" with some requests (I believe POSTs over a certain size).
  • By default, lighttpd rejects "Expect: 100 continue" with a 417 error and kills the request.
  • There's no practical benefit for us to sending this header (it's "nicer", but probably a little slower if anything).
  • The "correct" way to disable this behavior is to add an empty "Expect" header.

Test Plan: Confirmed resolved by @jucrouzet in T2612.

Reviewers: vrana, chad

Reviewed By: chad

CC: jucrouzet, aran

Maniphest Tasks: T2612

Differential Revision: https://secure.phabricator.com/D5136

Details

Committed
epriestley <git@epriestley.com>Feb 27 2013, 16:33
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU611913d02697: Take blocks into account into Diviner highlighter
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU219da1f53bfa: Disable cURL "Expect:" header (authored by epriestley <git@epriestley.com>).Feb 27 2013, 16:33