Homec4science
Diffusion libphutil 22285e941272

Fix excessively aggressive capturing of hyperlinks in Remarkup
22285e941272
Actions

Authored by epriestley <git@epriestley.com> on Jan 15 2014, 20:31.

Description

Fix excessively aggressive capturing of hyperlinks in Remarkup

Summary: Fixes T4319. See that task for examples. The "ungreedy" hyperlink rule is still a bit too greedy.

Test Plan: Added failing tests, made them pass.

Reviewers: btrahan, Firehed

Reviewed By: Firehed

CC: aran

Maniphest Tasks: T4319

Differential Revision: https://secure.phabricator.com/D7974

Details

Committed
epriestley <git@epriestley.com>Jan 15 2014, 20:31
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU89eacbccb053: Make "unable to create temporary directory" error slightly more clear
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU22285e941272: Fix excessively aggressive capturing of hyperlinks in Remarkup (authored by epriestley <git@epriestley.com>).Jan 15 2014, 20:31

Changes (4)

Path
Msrc/markup/engine/__tests__/remarkup/link-brackets.txt
Asrc/markup/engine/__tests__/remarkup/link-mixed.txt
Msrc/markup/engine/remarkup/PhutilRemarkupBlockStorage.php
Msrc/markup/engine/remarkup/markuprule/PhutilRemarkupRuleHyperlink.php

rPHU22285e941272

View Options

src/markup/engine/__tests__/remarkup/link-brackets.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/link-mixed.txt

Loading...
View Options

src/markup/engine/remarkup/PhutilRemarkupBlockStorage.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleHyperlink.php

Loading...
c4science ยท Help