Improve parsing of docblock specials
237549280f08
Actions

Authored by Joshua Spence <josh@freelancer.com> on Aug 23 2016, 02:15.

Description

Improve parsing of docblock specials

Summary:
Currently the tags of following docblock are parsed as array('special' => "foo\nbar"). This diff changes the output to be array('special' => array('foo', 'bar')).

/**
 * @special foo
 * @special bar
 */

Test Plan: Ran unit tests.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D16431

Details

Committed

Joshua Spence <josh@freelancer.com>

Aug 23 2016, 04:13

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHU9c03af69571f: Record the last time a connection was used on the connection object

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rPHU237549280f08: Improve parsing of docblock specials (authored by Joshua Spence <josh@freelancer.com>).Aug 23 2016, 04:13

Changes (5)

				Path
	M			src/parser/PhutilDocblockParser.php
	M			src/parser/__tests__/PhutilDocblockParserTestCase.php
	A			src/parser/__tests__/docblock/mixed-types.docblock
	M			src/parser/__tests__/docblock/multi-specials.docblock
	M			src/parser/__tests__/docblock/specials.docblock