Homec4science

Fix Filesystem::executeRemovePath

Authored by Nick Harper <nharper@fb.com> on Feb 8 2013, 04:14.

Description

Fix Filesystem::executeRemovePath

Summary:
Filesystem::remove() (implemented by executeRemovePath()) was broken for
symlinks to directories because is_dir returns true for symlinks to directories
in php.

Test Plan:
Tested in hphpd that is_dir() returns true for symlinks to directories, and that
unlink() instead of rmdir() will remove them (rmdir() won't remove them).
I haven't tested this code specifically.

Reviewers: epriestley, vrana

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4861

Details

Committed
Nick Harper <nharper@fb.com>Feb 8 2013, 04:14
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUcb3e15803a03: Use cURL multi interface in HTTPSFuture
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPHU2ff289b8fa6a: Fix Filesystem::executeRemovePath (authored by Nick Harper <nharper@fb.com>).Feb 8 2013, 04:14