Remove n_XHP_ENTITY from the XHPAST parse tree.
3a2367eb1feb
Actions

Authored by epriestley <epriestley@javelinjs.com> on Jan 28 2011, 19:24.

Description

Remove n_XHP_ENTITY from the XHPAST parse tree.

Summary: This node is redundant with n_XHP_TEXT and we currently emit confusing
and inconsistent parse trees for "<x>a &</x>" vs "<x>& a</x>". If you
care about the distinction the information is available at the token level so
there's no loss of generality in removing this node.

Test Plan:

Reviewers:

CC:

Details

Committed

epriestley <epriestley@javelinjs.com>

Jan 28 2011, 19:24

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHU24e0eb45f54e: Move DivinerDocblockParser to Phutil as PhutilDocblockParser.

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <epriestley@javelinjs.com> committed rPHU3a2367eb1feb: Remove n_XHP_ENTITY from the XHPAST parse tree. (authored by epriestley <epriestley@javelinjs.com>).Jan 28 2011, 19:24

Changes (6)

				Path
	M			src/parser/xhpast/bin/xhpast_parse.php
	M			src/parser/xhpast/constants/parser_nodes.php
	M			support/xhpast/generate_nodes.php
	M			support/xhpast/parser.y
	M			support/xhpast/parser_nodes.php
	M			support/xhpast/xhpast.cpp