Homec4science

Fix the handling of empty keys in `PhutilJSONParser`.

Authored by Joshua Spence <josh@joshuaspence.com> on Jun 20 2014, 02:27.

Description

Fix the handling of empty keys in PhutilJSONParser.

Summary:
Because the empty string is not a valid property of stdClass, the original JsonLint library replaced empty keys with '_empty_'. After D9623, all instances of stdClass have been replaced by arrays, so we can remove this nonsense.

Depends on D9623.

Test Plan: Added a test case and ran arc unit.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9633

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jun 20 2014, 02:27
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUdd7f571b61ed: Modify the JsonLint library to return `array` instead of `stdClass`.
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHU3bd9044d42bb: Fix the handling of empty keys in `PhutilJSONParser`. (authored by Joshua Spence <josh@joshuaspence.com>).Jun 20 2014, 02:27