Homec4science

Allow PhutilChannels to have their write channels closed explicitly

Authored by epriestley <git@epriestley.com> on Nov 11 2013, 21:03.

Description

Allow PhutilChannels to have their write channels closed explicitly

Summary: Ref T2230. This simplifies some tests and cleans up some TODOs in the hosting stuff. See testCloseExecWriteChannel for an example of where we need this in practice.

Test Plan: Ran unit tests; commented out the closeWriteChannel() calls and got test failures instead of hangs.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2230

Differential Revision: https://secure.phabricator.com/D7552

Details

Committed
epriestley <git@epriestley.com>Nov 11 2013, 21:03
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUfc94c397b410: Allow self-closing <frame>
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU3ef0937680ad: Allow PhutilChannels to have their write channels closed explicitly (authored by epriestley <git@epriestley.com>).Nov 11 2013, 21:03