Homec4science

Allow libphutil to start up in the presence of missing global functions

Authored by epriestley <git@epriestley.com> on Aug 28 2012, 03:39.

Description

Allow libphutil to start up in the presence of missing global functions

Summary:
See D3393.

  • When we fail to load a symbol, try to load everything else before we throw. Throw an arbitrary one of the failure(s) since it's not terribly important which one we pick.
  • When loading global functions fails, proceed anyway.

Test Plan: Removed a function, ran arc liberate, it was nuked from the library map.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D3395

Details

Committed
epriestley <git@epriestley.com>Aug 28 2012, 03:39
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU2ea6908e3b71: Minor, fix an XHPAST Makefile path. See T1717.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU41578097e663: Allow libphutil to start up in the presence of missing global functions (authored by epriestley <git@epriestley.com>).Aug 28 2012, 03:39