Homec4science

Choose a better class name for PhutilMethodNotImplementedException

Authored by epriestley <git@epriestley.com> on Jul 25 2014, 00:55.

Description

Choose a better class name for PhutilMethodNotImplementedException

Summary:
If you call $subclass->method() and the base class provides a default implementation which throws, you get BaseClass in the exception message.

Instead, produce Subclass in this case.

Test Plan: With Application subclasses missing getName() implementations, got more useful exceptions (e.g., "PhabricatorPasteApplication" is missing a method, not "PhabricatorApplication").

Reviewers: joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D10030

Details

Committed
epriestley <git@epriestley.com>Jul 25 2014, 00:55
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU702046d23645: Rename `HTTPFutureResponseStatus` subclasses
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU4298b0da1573: Choose a better class name for PhutilMethodNotImplementedException (authored by epriestley <git@epriestley.com>).Jul 25 2014, 00:55