Homec4science

Split Remarkup rule for document link from hyperlink

Authored by vrana <jakubv@fb.com> on Aug 8 2012, 03:42.

Description

Split Remarkup rule for document link from hyperlink

Summary:
We have other rules dealing with hyperlinks (PhabricatorRemarkupRuleProxyImage) which collides with one rule for hyperlink:

  • If we apply proxy image first then it creates [[ storedText ]] which builds an invalid link.
  • If we apply hyperlink first then there's nothing left for proxy image.

Test Plan: [[ http://example.com/a.png | a ]]

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3191

Details

Committed
vrana <jakubv@fb.com>Aug 8 2012, 03:50
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUa35a81cc7bcd: Provide prompt for console server
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHU45f7bd6ad1dd: Split Remarkup rule for document link from hyperlink (authored by vrana <jakubv@fb.com>).Aug 8 2012, 03:50