Homec4science

Improve the `PhutilInfrastructureTestCase` unit tests

Authored by Joshua Spence <josh@joshuaspence.com> on Jul 5 2014, 17:21.

Description

Improve the PhutilInfrastructureTestCase unit tests

Summary:
Improve the PhutilInfrastructureTestCase unit tests such that they will fail if any of the following conditions are satisfied:

  • A symbol referenced in the __phutil_library_map__.php file no longer exists.
  • A symbol exists in the library but is not referenced within the __phutil_library_map__.php file.
  • A symbol extends from a different parent symbol than that declared in the __phutil_library_map.php file.

Test Plan: Added a new function. Ran arc unit and observed the test failure.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9824

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jul 5 2014, 17:21
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU8f18a7207030: Move `PhutilLibraryMapBuilder` into the standard directory structure
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHU4620dbb05d75: Improve the `PhutilInfrastructureTestCase` unit tests (authored by Joshua Spence <josh@joshuaspence.com>).Jul 5 2014, 17:21