Homec4science

Emit exit event from daemon handle when daemon is not running

Authored by epriestley <git@epriestley.com> on Feb 23 2015, 20:29.

Description

Emit exit event from daemon handle when daemon is not running

Summary:
Ref T7352. Currently, if you ^C a daemon while the subprocess is not running (e.g., wiating to restart after a failure) we just exit without actually emitting the EXIT event.

This can leave the daemon log hanging around in the database until it eventually expires.

Instead, make sure this event always gets emitted when a daemon responds to ^C.

Test Plan: With failing tasks in queue so that the taskmasters exit immediately, ran phd start and then phd stop a few times. Preivously, this would leave phantom daemons; now it cleans them up.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7352

Differential Revision: https://secure.phabricator.com/D11866

Details

Committed
epriestley <git@epriestley.com>Feb 24 2015, 23:49
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUe6cc2aaa36f7: Implement memory reserves in autoscale pools
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU46764a249766: Emit exit event from daemon handle when daemon is not running (authored by epriestley <git@epriestley.com>).Feb 24 2015, 23:49