Detect URLs in Remarkup more craftily
46e554e0123a
Actions

Authored by epriestley <git@epriestley.com> on Sep 21 2011, 23:01.

Description

Detect URLs in Remarkup more craftily

Summary: See T515. There are some edge cases with parens which we don't handle
as nicely as we could, refine the parser behavior.

Test Plan: Ran unit tests.

Reviewers: Girish, jungejason, nh, tuomaspelkonen, aran

Reviewed By: Girish

CC: aran, jungejason, epriestley, Girish

Differential Revision: 952

Committed

epriestley <git@epriestley.com>

Sep 22 2011, 00:31

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHUfc50ddd47a71: Fix clownslop in D903.

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPHU46e554e0123a: Detect URLs in Remarkup more craftily (authored by epriestley <git@epriestley.com>).Sep 22 2011, 00:31

				Path
	M			src/markup/engine/remarkup/__tests__/data/across-newlines.txt
	M			src/markup/engine/remarkup/__tests__/data/entities.txt
	M			src/markup/engine/remarkup/__tests__/data/link-brackets.txt
	A			src/markup/engine/remarkup/__tests__/data/link-edge-cases.txt
	M			src/markup/engine/remarkup/__tests__/data/link.txt
	M			src/markup/engine/remarkup/__tests__/data/list.txt
	M			src/markup/engine/remarkup/__tests__/data/note.txt
	M			src/markup/engine/remarkup/__tests__/data/simple.txt
	M			src/markup/engine/remarkup/markuprule/hyperlink/PhutilRemarkupRuleHyperlink.php
	M			src/parser/docblock/__tests__/data/embedded-specials.docblock
	M			src/parser/docblock/__tests__/data/indented-block.docblock
	M			src/parser/docblock/__tests__/data/indented-specials.docblock
	M			src/parser/docblock/__tests__/data/indented-text.docblock
	M			src/parser/docblock/__tests__/data/linebreak-breaks-specials.docblock
	M			src/parser/docblock/__tests__/data/multi-specials.docblock
	M			src/parser/docblock/__tests__/data/multiline-special.docblock
	M			src/parser/docblock/__tests__/data/specials.docblock
	M			support/xhpast/ast.hpp
	M			support/xhpast/astnode.cpp
	M			support/xhpast/astnode.hpp
	M			support/xhpast/parser.y
	M			support/xhpast/parser_nodes.php
	M			support/xhpast/scanner.l
	M			support/xhpast/xhpast.cpp