Homec4science

Add a "concrete only" flag to PhutilSymbolLoader

Authored by epriestley <git@epriestley.com> on Jan 25 2012, 20:46.

Description

Add a "concrete only" flag to PhutilSymbolLoader

Summary: We have a few cases where we only want to load concrete subclasses.
Currently, we have the same ReflectionClass block copy/pasted a few places;
simplify it by putting the logic in PhutilSymbolLoader.

Test Plan: Modified Drydock, Conduit and phd to use setConcreteOnly(), ran "phd
list", visited conduit API console, hit Drydock "allocate resource" endpoint,
saw correct behavior.

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T801

Differential Revision: https://secure.phabricator.com/D1486

Details

Committed
epriestley <git@epriestley.com>Jan 25 2012, 20:46
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUb2502e6ca550: Minor, fix spelling mistake detected by spelling linter.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU470d2d13778f: Add a "concrete only" flag to PhutilSymbolLoader (authored by epriestley <git@epriestley.com>).Jan 25 2012, 20:46